Changeset 15890 for gsdl/trunk/perllib/GDBMUtils.pm

Timestamp:

2008-06-06T11:04:57+12:00 (16 years ago)

Author:

mdewsnip

Message:

Adding "use strict", and fixing problems identified.

File:

• gsdl/trunk/perllib/GDBMUtils.pm (modified) (4 diffs)

gsdl/trunk/perllib/GDBMUtils.pm

@@ -1 +1 @@
 package GDBMUtils;
 
+use strict;
 use util;
 
-$debug = 0;
+my $debug = 0;
 
 # /** Global variable to hold a string containing the last collection a gdbmGet 
@@ -42 +43 @@
       }
     # Where's the database?
-    $database = &getDatabasePath($collection);
+    my $database = &getDatabasePath($collection);
     # Are we in windows? Do we need .exe?
-    $exe = "";
+    my $exe = "";
     $exe = ".exe" if $ENV{'GSDLOS'} =~ /^windows$/i;
     # Retrieve the raw document content
     print STDERR "#Get document\ncmd: gdbmget$exe \"$database\" \"$oid\"\n" if $debug;
-    $value = `gdbmget$exe "$database" "$oid"`;
+    my $value = `gdbmget$exe "$database" "$oid"`;
     # Tidy up the ever growing number of newlines at the end of the value
     $value =~ s/(\r?\n)+/$1/g;
@@ -73 +74 @@
     my ($collection, $oid, $value) = @_;
     # Where's the database?
-    $database = &getDatabasePath($collection);
+    my $database = &getDatabasePath($collection);
     # Are we in windows? Do we need .exe?
     my $exe = &util::get_os_exe();
@@ -108 +109 @@
 sub getDatabasePath()
   {
-    $collection = shift(@_);
+    my $collection = shift(@_);
     # Find out the database extension
     my $ext = ".bdb";