Changeset 18234 for greenstone3/trunk/src/java/org/greenstone/gsdl3/LibraryServlet.java

Timestamp:

2008-12-17T15:57:59+13:00 (15 years ago)

Author:

oranfry

Message:

changing the library servlet code for checking the el, href and rl query arguments, which until now would see el=direct as the same as elx=direct or elephant=direct - i.e. it would be satisfied as long as the first part of the argument name was correct. It is appropriate to expect an exact match so check for 'el=' instead of just 'el' and so on

File:

• greenstone3/trunk/src/java/org/greenstone/gsdl3/LibraryServlet.java (modified) (2 diffs)

greenstone3/trunk/src/java/org/greenstone/gsdl3/LibraryServlet.java

@@ -286 +286 @@
       String rl = null;
       for (int i=0;i<query_arr.length;i++){
-        if (query_arr[i].startsWith("el")){
+        if (query_arr[i].startsWith("el=")){
           if (query_arr[i].substring(query_arr[i].indexOf("=")+1,query_arr[i].length()).equals("direct")){
             redirect = true;
           }
-        }else if(query_arr[i].startsWith("href")){
+        }else if(query_arr[i].startsWith("href=")){
           href = query_arr[i].substring(query_arr[i].indexOf("=")+1,query_arr[i].length());
           href = href.replaceAll("%2f", "/");
@@ -296 +296 @@
           href = href.replaceAll("%3f", "?");
           href = href.replaceAll("%3A", "\\:");
-        }else if(query_arr[i].startsWith("rl")){
+        }else if(query_arr[i].startsWith("rl=")){
           rl = query_arr[i].substring(query_arr[i].indexOf("=")+1,query_arr[i].length());
         }