Changeset 18320 for gsdl/trunk/perllib/plugins/ConvertBinaryFile.pm

Timestamp:

2009-01-06T19:03:58+13:00 (15 years ago)

Author:

ak19

Message:

Now plugins provide the option of base64 encoding or url encoding filenames that are to be renamed (when copied into the archives dir). Previously renamed files would always be url-encoded. URL-encoding is the default now for most plugins except MP3Plugin and OggVorbisPlugin, where the default is base64 encoding. Base64 encoding filenames upon renaming them was introduced so that more files that browsers try to open in external applications can open them, since url encoding does not seem to be implemented the same everywhere (for instance, windows media player is unable to handle url-encoded wmv filenames when such files are launched in it through the browser).

File:

• gsdl/trunk/perllib/plugins/ConvertBinaryFile.pm (modified) (2 diffs)

gsdl/trunk/perllib/plugins/ConvertBinaryFile.pm

@@ -284 +284 @@
     # to work on Windows (IE or Firefox), as browsers are looking for filesystem-encoded
     # files on the filesystem.
-    $tailname = &unicode::url_encode($tailname);
+    $tailname = &util::rename_file($tailname, $self->{'file_rename_method'});
 
     $suffix = lc($suffix);
@@ -429 +429 @@
     my $collect_file = &util::filename_within_collection($filename_full_path);
     my $collect_conv_file = &util::filename_within_collection($conv_filename);
-    $doc_obj->set_source_filename ($collect_file); 
+    $doc_obj->set_source_filename ($collect_file, $self->{'file_rename_method'}); 
     $doc_obj->set_converted_filename($collect_conv_file);