Changeset 20976 for gsdl/trunk/common-src/packages

Timestamp:

2009-11-27T16:56:24+13:00 (14 years ago)

Author:

mdewsnip

Message:

Added a safety check provided by Andrew Brooks (University of Dundee) for ensuring that a database with the wrong byte order for the machine cannot be opened for writing. (The byte swapping code that I did has only been done for reading, not writing).

File:

• gsdl/trunk/common-src/packages/gdbm/gdbm-1.8.3/gdbmopen.c (modified) (1 diff)

gsdl/trunk/common-src/packages/gdbm/gdbm-1.8.3/gdbmopen.c

@@ -381 +381 @@
       wrong_endianness = (partial_header.header_magic == 0xCE9A5713);
 
+      // GREENSTONE CUSTOMISATION (thanks to Andrew Brooks): prevent write access to wrong-byte-order databases
+      if (wrong_endianness && ((flags & GDBM_OPENMASK) != GDBM_READER))
+      {
+        gdbm_close (dbf);
+        gdbm_errno = GDBM_CANT_BE_WRITER;
+        return NULL;
+      }
+
       // GREENSTONE CUSTOMISATION: Swap each value in the partial header if the GDBM file is the wrong endianness
       if (wrong_endianness)