Changeset 26993 for gs2-extensions/tdb-edit

Timestamp:

2013-03-05T10:34:45+13:00 (11 years ago)

Author:

jmt12

Message:

Changed client to retry connections every second, but also to timeout after five minutes of failing to connect (according to RFC793 there may be a waiting time of up to four minutes for TIME_WAIT sockets to be reaped... so after five minutes it shouldn't be an exhausted socket pool causing the issue)

File:

• gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolClient.pm (modified) (4 diffs)

gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolClient.pm

@@ -10 +10 @@
 use warnings;
 
-my $retry_time = 5;
+my $retry_limit = 300; # five minute
+my $retry_time = 1;
 
 sub new
@@ -50 +51 @@
   # (according to RFC793) we may be waiting up to 4 minutes for TIME_WAITs to
   # be reaped. Sigh. Still - ever an optimist - I'll retry the socket
-  # connection every 30 seconds.
+  # connection every seconds.
   # References:
   #   http://www.perlmonks.org/?node_id=771242
@@ -57 +58 @@
   #   http://www.isi.edu/touch/pubs/infocomm99/infocomm99-web/
   #   http://www.faqs.org/rfcs/rfc793.html
-  while(1)
+  while($retry_limit > 0)
   {
     my $socket= new IO::Socket::INET(PeerAddr => $self->{host} || 'localhost',
@@ -70 +71 @@
     print "=> Retry in " . $retry_time . " seconds.\n";
     sleep($retry_time);
+    $retry_limit--;
   }
+  print "Error! Failed to create client socket within 5 minutes timeout.\n";
 }