Changeset 26996

Show
Ignore:
Timestamp:
05.03.2013 11:03:28 (7 years ago)
Author:
jmt12
Message:

Commenting out the bit that waits (adding a significant delay to test runs) for TDBServers to cleanly exit. If an exit somehow fails, the TDB lockfile will be left behind prevent other TDBServers from starting up. While this may cause a series of test to not run, it won't result in inconsistent results as I initially worried

Files:
1 modified

Legend:

Unmodified
Added
Removed
  • gs2-extensions/tdb-edit/trunk/src/perllib/dbutil/tdbserver.pm

    r26994 r26996  
    163163  # removed (otherwise people could mistakenly run import/build again 
    164164  # immediately and things *might* go pearshaped). 
    165   foreach my $server_lockfile_path (keys (%created_server_lockfile_paths)) 
    166   { 
    167     # While the file exists, we should wait 
    168     print "* Waiting for TDBServer [" . $server_lockfile_path . "] to exit..."; 
    169     if (-e $server_lockfile_path) 
    170     { 
    171       while (-e $server_lockfile_path) 
    172       { 
    173         print "."; 
    174         sleep(1); 
    175       } 
    176     } 
    177     print " Done!\n"; 
    178   } 
     165  # - actually, if they try to run again while TDB is still running, it will 
     166  #   detect an existing lockfile and immediately quit. So maybe waiting 
     167  #   isn't as important as I originally thought. I'll comment it out for now. 
     168#  foreach my $server_lockfile_path (keys (%created_server_lockfile_paths)) 
     169#  { 
     170#    # While the file exists, we should wait 
     171#    print "* Waiting for TDBServer [" . $server_lockfile_path . "] to exit..."; 
     172#    if (-e $server_lockfile_path) 
     173#    { 
     174#      while (-e $server_lockfile_path) 
     175#      { 
     176#        print "."; 
     177#        sleep(1); 
     178#      } 
     179#    } 
     180#    print " Done!\n"; 
     181#  } 
    179182} 
    180183