Changeset 26996 for gs2-extensions/tdb-edit/trunk/src/perllib/dbutil/tdbserver.pm

Timestamp:

2013-03-05T11:03:28+13:00 (11 years ago)

Author:

jmt12

Message:

Commenting out the bit that waits (adding a significant delay to test runs) for TDBServers to cleanly exit. If an exit somehow fails, the TDB lockfile will be left behind prevent other TDBServers from starting up. While this may cause a series of test to not run, it won't result in inconsistent results as I initially worried

File:

• gs2-extensions/tdb-edit/trunk/src/perllib/dbutil/tdbserver.pm (modified) (1 diff)

gs2-extensions/tdb-edit/trunk/src/perllib/dbutil/tdbserver.pm

@@ -163 +163 @@
   # removed (otherwise people could mistakenly run import/build again
   # immediately and things *might* go pearshaped).
-  foreach my $server_lockfile_path (keys (%created_server_lockfile_paths))
-  {
-    # While the file exists, we should wait
-    print "* Waiting for TDBServer [" . $server_lockfile_path . "] to exit...";
-    if (-e $server_lockfile_path)
-    {
-      while (-e $server_lockfile_path)
-      {
-        print ".";
-        sleep(1);
-      }
-    }
-    print " Done!\n";
-  }
+  # - actually, if they try to run again while TDB is still running, it will
+  #   detect an existing lockfile and immediately quit. So maybe waiting
+  #   isn't as important as I originally thought. I'll comment it out for now.
+#  foreach my $server_lockfile_path (keys (%created_server_lockfile_paths))
+#  {
+#    # While the file exists, we should wait
+#    print "* Waiting for TDBServer [" . $server_lockfile_path . "] to exit...";
+#    if (-e $server_lockfile_path)
+#    {
+#      while (-e $server_lockfile_path)
+#      {
+#        print ".";
+#        sleep(1);
+#      }
+#    }
+#    print " Done!\n";
+#  }
 }