Changeset 27652 for gs2-extensions

Timestamp:

2013-06-18T10:51:56+12:00 (11 years ago)

Author:

jmt12

Message:

Changing buffer to 128K (slightly faster) and adding a comment explaining the number of bytes we expect to be returned by read may be larger than buffersize due to encoding

File:

• gs2-extensions/parallel-building/trunk/src/perllib/FileUtils/HDThriftFS.pm (modified) (2 diffs)

gs2-extensions/parallel-building/trunk/src/perllib/FileUtils/HDThriftFS.pm

@@ -78 +78 @@
 my $debug = 0;
 my $debug_encoding = 0;
-# Testing shows 64k is pretty optimal
+# Testing shows 128k is pretty optimal
 #my $buffer_length =    4 * 1024; # 4k blocks
 #my $buffer_length =    8 * 1024; # 8k blocks
@@ -760 +760 @@
   open($fhout, '>:raw', $dst) or die("Failed to open file for writing: " . $dst);
   my $fhin = $thrift_client->open($src_path);
+  # Read buffer_length *decoded* bytes - which means there may be a larger
+  # number of *encoded* bytes returned
   while ($encoded = $thrift_client->read($fhin, $offset, $buffer_length))
   {