Changeset 27859

Timestamp:

2013-07-15T19:55:58+12:00 (11 years ago)

Author:

ak19

Message:

Bugfix. On Windows, when GLI launches the GS3server, the perl path found is env.PERLPATH since GLI uses findperl.bat to locate the path to perl bin. By the time the ant target perl-for-building determines the perl path, env.PERLPATH needs to have a slash appended at the end, else the path to perl appears as binperl instead of bin\perl in packages\tomcat\conf\web.xml, and then metadata edited with the online meta editor don't get saved since the metadata-server.pl script can't find perl. This is not a problem if the GS3 server is not launched through GLI, since ant target perl-for-building goes into another branch of its logic to locate perlpath.

File:

• main/trunk/greenstone3/build.xml (modified) (1 diff)

main/trunk/greenstone3/build.xml

@@ -709 +709 @@
             </and>
           </bool>
-          <property name="perl.path" value="${env.PERLPATH}"/>
+          <!-- set perlpath to env.PERLPATH. 
+            This is the path to perl\bin that's found by findperl.bat when the server is launched 
+            through GLI instead of the console.
+            For windows, this env.PERLPATH is the bin folder and needs a backslash at end, since it 
+            will appear suffixed with "perl.exe" in the perl setting in packages\tomcat\config\web.xml. 
+            This web.xml's path to perl is then used to find perl when running the perl scripts in the 
+            cgi folder, so without a slash appended at this point it becomes "binperl" in web.xml, and 
+            things will break when GLI launches the server on Windows and the online GS3 metadata editor 
+            is used to save user-edited metadata. -->
+          <if><bool><istrue value="${current.os.iswindows}"/></bool>
+            <property name="perl.path" value="${env.PERLPATH}\"/>
+          <else>
+            <property name="perl.path" value="${env.PERLPATH}"/>
+          </else>   
+          </if>
+          
           <else>
             <echo>