Changeset 28776 for gs2-extensions/tdb-edit

Timestamp:

2013-12-18T12:53:06+13:00 (10 years ago)

Author:

jmt12

Message:

opps.. left one join behind. fixed now, and added comment about the lingering problem of the main thread exiting while child threads still exist (prompting the 'a thread exited while X threads were still running' warning message)

File:

• gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolServer.pm (modified) (5 diffs)

gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolServer.pm

@@ -2 +2 @@
 # @url    https://github.com/macnod/DcServer
 # @readme http://donnieknows.com/blog/perl-sockets-swimming-thread-pool
+
+# One lurking issue with the ThreadPoolServer is that several threads don't get
+# a chance to return before the server shuts down. In a perfect world they'd
+# all get a chance to notice the 'stop' flag has been set and thusly
+# stop. However, it is only by chance this happens as most will spend most of
+# their lives either blocked listening to a socket (accept_requests) or blocked
+# waiting to dequeue a message (request_handlers). Possible solutions, such as
+# interupts, have problems of their own - interrupting mid-read of a socket
+# could be bad.  Since this is non-fatal, and non-trivial to fix, I'm just
+# leaving it for now.
 
 package SocketsSwimmingThreadPoolServer;
@@ -28 +38 @@
       LocalPort => $param{port} || 8191},
     thread_count => $param{thread_count} || 10,
-    main_yield => $param{main_yield} || 5,
+    main_yield => $param{main_yield} || 1,
     main_cb => $param{main_cb} || sub {},
     done_cb => $param{done_cb} || sub {},
@@ -68 +78 @@
 sub stop
 {
-  my $self= shift;
+  my $self = shift;
   $stop= 1;
 }
@@ -94 +104 @@
     if (!defined $lsocket || !$lsocket)
     {
-      print STDERR "Error! Can't create listerner socket so server can't start (trying again in 1 second). Error message: \"" . $! . "\"\n";
+      print STDERR "Warning! Can't create listener socket so server can't start (trying again in 1 second).\n";
+      print STDERR "Error message: \"" . $! . "\"\n\n";
       sleep(1);
     }
@@ -162 +173 @@
     $closed_queue->enqueue($n);
   }
-
-  # Shouldn't join() detached threads?
-  # Properly rejoin thread
-  # Newer versions of module thread
-  #if (defined $self->can('is_joinable'))
-  #{
-  #  print "[debug] using newer thread->is_joinable... ";
-  #  if ($self->is_joinable())
-  #  {
-  #    $self->join();
-  #    print "joined\n";
-  #  }
-  #  else
-  #  {
-  #    print "not joinable\n";
-  #  }
-  #}
-  #else
-  #{
-  #  print "[debug] using newer thread->is_detached... ";
-  #  my $thread = threads->self();
-  #  if (!$thread->is_detached())
-  #  {
-  #    $thread->join();
-  #    print "joined\n";
-  #  }
-  #  else
-  #  {
-  #    print "not detached\n";
-  #  }
-  #}
 }