Changeset 29332 for main/trunk

Timestamp:

2014-09-24T14:05:09+12:00 (10 years ago)

Author:

kjdon

Message:

alert, confirm, prompt no longer allowed in beforeunload. Just use the default prompt - do you want to leave? leave/stay. Custom text can no longer be added to this either, so I have a help message that is invisible to start with. Make it visible when the user clicks off the page so that if they stay on the page they get some indication of what they need to do.

File:

• main/trunk/greenstone3/web/interfaces/default/transform/pages/pref.xsl (modified) (3 diffs)

main/trunk/greenstone3/web/interfaces/default/transform/pages/pref.xsl

@@ -34 +34 @@
     <input type='hidden' name='c' value="{$collName}"/>
 
+    <p id="SaveInstructions" style="color:red; text-align:center; display:none;"><xsl:value-of select="util:getInterfaceText($interface_name, /page/@lang, 'pref.set_prefs_help')"/></p>
     <xsl:call-template name="presentation-prefs"/>
     <xsl:call-template name="search-prefs"/>
@@ -65 +66 @@
     <xsl:template name="prefs-javascript">
         <!-- 
-        Add some javascript to the page that notices when a preference is changed 
-        so that, if the user tries to navigate away from the page without clicking
-        the "Set preferences" button, it asks them if they want their preferences
-        saved or not 
-        -->
+        Add some javascript to the page that notices when a preference 
+           is changed so that, if the user tries to navigate away from 
+           the page without clicking the "Set preferences" button, it 
+           gives a stay/leave dialog. -->
         <script type="text/javascript"><xsl:text disable-output-escaping="yes">
             var modified = false;
             var bypass = false;
                     
-            function assembleURLFromForm(formElem)
-            {
-                var url = gs.xsltParams.library_name + "?";
-                var selectNodes = formElem.getElementsByTagName("select");
-                var inputNodes = formElem.getElementsByTagName("input");
-
-                for (var i = 0; i &lt; selectNodes.length; i++)
-                {
-                    var current = selectNodes[i];
-                    url += current.name + "=";
-                    url += current.options[current.selectedIndex].text + "&amp;";
-                }
-                
-                for (var i = 0; i &lt; inputNodes.length; i++)
-                {
-                    var current = inputNodes[i];
-                    if (current.type == "hidden" || current.type == "text")
-                    {
-                        url += current.name + "=";
-                        url += current.value + "&amp;";
-                    }
-                }
-                return url;
+            function unsavedChanges(e) {
+            if (modified &amp;&amp; !bypass) {
+            document.getElementById("SaveInstructions").style.display="block";
+            return "Provide the prompt";
             }
-                    
-            function checkModified(e)
-            {
-                if (modified &amp;&amp; !bypass)
-                {
-                    var ok = confirm("Would you like to save your preferences?");
-                    
-                    if (ok)
-                    {
-                        var formElem = document.getElementById("prefform");
-                        formElem.submit();
-                        var xmlhttp;
-                        if (window.XMLHttpRequest)
-                        {
-                            xmlhttp=new XMLHttpRequest();
-                        }
-                        else
-                        {
-                            xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
-                        }
-
-                        xmlhttp.open("GET",assembleURLFromForm(formElem),false);
-                        xmlhttp.send();
-                    }
-                }
+            // no return statement - no dialog will be shown
             }
             
@@ -151 +108 @@
             
             YAHOO.util.Event.addListener(window, 'load', pageLoad);
-            YAHOO.util.Event.addListener(window, 'beforeunload', checkModified);
+            $(window).bind("beforeunload", unsavedChanges);
         </xsl:text></script>
     </xsl:template>