Changeset 2973

Timestamp:

2002-02-19T22:15:04+13:00 (22 years ago)

Author:

sjboddie

Message:

Fixed a bug in the Hierarchy classifier

File:

• trunk/gsdl/perllib/classify/Hierarchy.pm (modified) (1 diff)

trunk/gsdl/perllib/classify/Hierarchy.pm

@@ -230 +230 @@
     $classifyinfo->{'Title'} = $title;
     $classifyinfo->{'classifytype'} = $classifytype;
+
     return $classifyinfo;
     }
 
     $classifyinfo->{'contains'} = [] unless defined $classifyinfo->{'contains'};
-    
-    # add entries to the contains list until we have one for headOID
-    #### the +10 is a hack that works but I'm not completely sure why 
-    #### and don't have time to delve deeper. one day someone should 
-    #### fix this ;-) -- Stefan
-    while (scalar(@{$classifyinfo->{'contains'}}) <= ($headOID+10)) {
+
+    my $offset = 0;
+    foreach $thing (@{$classifyinfo->{'contains'}}) {
+    $offset ++ if defined $thing->{'OID'};
+    }
+    
+    while (scalar(@{$classifyinfo->{'contains'}}) < ($headOID+$offset)) {
     push (@{$classifyinfo->{'contains'}}, $self->get_entry("", $classifytype));
     }
 
-    return $self->get_OID_entry ($tailOID, $classifyinfo->{'contains'}->[($headOID-1)], $title, $classifytype);
+    return $self->get_OID_entry ($tailOID, $classifyinfo->{'contains'}->[($headOID+$offset-1)], $title, $classifytype);
 }