Changeset 30052 for main/trunk/release-kits/kits

Timestamp:

2015-07-22T20:27:19+12:00 (9 years ago)

Author:

ak19

Message:

Installer language selection now uses a dropdown in place of radio buttons to accomodate additional language translations submitted for the gsinstaller module. To get the dropdown <large-select> to work like the radio buttons <select>, Dr Bainbridge figured out that Oran had made some code changes to <select> in AntInstaller's LoadConfigFilter.java. Added the same change in for the <large-select> and then needed to port Oran's additional changes to SelectInput.java into LargeSelectInput.java (didn't put the changes in the superclass InputField.java since a lot of other AntInstaller classes inherit from that).

File:

• main/trunk/release-kits/kits/rk3/installer/antinstall-config.xml (modified) (2 diffs)

main/trunk/release-kits/kits/rk3/installer/antinstall-config.xml

@@ -13 +13 @@
 
     <!-- select language page -->
+    <!-- We want a dropdown for installer language selection.
+    <select> is rendered as radio buttons in the GUI version.
+    antinstaller.sourceforge.net/manual.html
+    <large-select>: "The large select has identical options to the select input. 
+    Large select enables the list of options to be greater and is displayed differently. 
+    In the Swing GUI the options are rendered as a drop-down list. 
+    In the text/console UI the options are shown to the user 20 lines at a time."
+    An example: https://github.com/ykyuen/maven-h2o/blob/master/h2o-installer/ant-installer/antinstall-config.xml
+    
+    However, to get <large-select> to work as <select> did, needed to modify the AntInstaller code itself
+    in release-kits\shared\core\ant-installer\src\org\tp23\antinstaller\runtime\exe\LoadConfigFilter.java,
+    and also bring the code in antinstaller\input\LargeSelectInput.java up to speed with Oran's changes to <select> 
+    in ant-installer\src\org\tp23\antinstaller\input\SelectInput.java
+    
+    <option value="hy" text="Armenian"/>
+    <option value="jp" text="日本語 (Japanese)"/>
+    -->
     <page type="input" name="language-selector" displayText="">
         <comment name="language-selector-explanation"/>
-        <select property="language" defaultValue="en" displayText="" useAsLocale="true">
+        <large-select property="language" defaultValue="en" displayText="" useAsLocale="true">
             <option value="en" text="English"/>
             <option value="fr" text="Français (French)"/>
@@ -23 +40 @@
             <option value="zh" text="äž­æ–‡ (Chinese)"/>
             <option value="ar" text="Arabic"/>
-        </select>
+            <option value="kk" text="Қазақ (Kazakh)"/>
+        </large-select>
     </page>