Changeset 30055 for main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/ModifyUsersDB.java

Timestamp:

2015-07-24T22:48:03+12:00 (9 years ago)

Author:

ak19

Message:

Fixing bug in GS3 installer that didn't use the longer password provided, despite the installer now allowing more than 8. The problem was bigger and manifold. 1. Fixed ModifyUsersDB to allow up to and incl 20 chars instead of 8. 2. Fixed the DerbyWrapper classes since the ant config-admin and config-user tasks had stopped working when global.properties was consulted for the derbyserver name and port. Now providing fallbacks again for the installer. 3. build.xml may no longer need to stop tomcat then modify the derby db and then start tomcat again because we're no longer using an embedded derby, but because we're using a networked derby, modifying the usersdb now didn't work unless greenstone (actually derby) was running. Changed the config targets to allow modifying admin and user data even if greenstone is not running, by making the update-userdb target that's called by these two tasks ensure the derbyserver is running before modifying the userdb, and stopping it if it was started up by the target.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/ModifyUsersDB.java (modified) (3 diffs)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/ModifyUsersDB.java

@@ -27 +27 @@
 public class ModifyUsersDB
 {
+    public static int PWD_MIN_LENGTH = 3;
+    public static int PWD_MAX_LENGTH = 20;
 
     public static void main(String[] args) throws SQLException
@@ -49 +51 @@
 
         // If the user specifically sets any of the fields on the cmdline, they'll be overwritten in the db, 
-        // even if the user had set them to empty. Except the password which must be between 3 and 8 characters.
+        // even if the user had set them to empty. Except the password which must be between PWD_MIN_LENGTH and PWD_MAX_LENGTH characters.
         for (int i = 2; i < args.length; i++)
         {
@@ -56 +58 @@
                 password = args[i].substring("password=".length());
 
-                if (password.length() < 3 || password.length() > 8)
+                if (password.length() < PWD_MIN_LENGTH || password.length() > PWD_MAX_LENGTH)
                 {
                     if (!password.equals(""))
                     {
-                        System.out.println("Password not updated. It should be between 3 and 8 characters (inclusive).");
+                        System.out.println("Password not updated. It should be between " + PWD_MIN_LENGTH + " and " + PWD_MAX_LENGTH + " characters (inclusive).");
                     }
                 }