Changeset 31572

Show
Ignore:
Timestamp:
05.04.2017 20:13:40 (2 years ago)
Author:
ak19
Message:

Minor changes ahead of more major ones. Explicitly marking ConstructionEvent? members immutable by declaring them final, to make them thread safe (to make them safe to share across multiple threads).

Location:
main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build
Files:
2 modified

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/CollectionConstructor.java

    r29869 r31572  
    2828    /** Stores the name of the manifest file (if one is needed) */ 
    2929    protected String manifest_file = null; 
    30     /** The URL params constructed as a query string, representing the CGI QUERY_STRING to */ 
     30    /** The URL params constructed as a query string, representing the CGI QUERY_STRING to the process */ 
    3131    protected String query_string = null; 
    3232 
     
    4545    } 
    4646 
     47    // this method never gets called. And, the way subclass GS2PerlConstructor.runPerlCommand() was originally 
     48    // coded, setting cancel to true never had any effect anyway in stopping any perl command that was run. 
    4749    public void stopAction() 
    4850    { 
  • main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/ConstructionEvent.java

    r5148 r31572  
    1010    private static final int EVENT_ID = RESERVED_ID_MAX+77; 
    1111    /** The status associated with the event. */ 
    12     private int status = -1; 
     12    private final int status; 
    1313    /** Any message associated with this event. */ 
    14     private String message = null; 
     14    private final String message; 
    1515    /* Constructor. 
    1616     * @param source The <strong>CollectionConstructor</strong> that fired this message.