Changeset 31577 for main

Timestamp:

2017-04-06T14:48:16+12:00 (7 years ago)

Author:

kjdon

Message:

changed my mind. now declaring aStr and bStr variables, cos what if the a and b coming in are not the same as global a and b?? maybe there is room for things to go wrong? so lets explicitly declare the variables

File:

• main/trunk/greenstone2/perllib/classify/List.pm (modified) (2 diffs)

main/trunk/greenstone2/perllib/classify/List.pm

@@ -976 +976 @@
 sub alpha_numeric_cmp
 {
-    my ($self) = shift (@_); 
-
-    if ($a =~ m/^(\d+(\.\d+)?)/)
+    my $self = shift (@_); 
+    my ($aStr, $bStr) = @_;
+    if ($aStr =~ m/^(\d+(\.\d+)?)/)
     {
         my $val_a = $1;
-        if ($b =~ m/^(\d+(\.\d+)?)/)
+        if ($bStr =~ m/^(\d+(\.\d+)?)/)
         {
             my $val_b = $1;
@@ -991 +991 @@
     }
     
-    return ($a cmp $b);
+    return ($aStr cmp $bStr);
 }