Changeset 31602 for main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/GS2PerlConstructor.java

Timestamp:

2017-04-19T21:35:50+12:00 (7 years ago)

Author:

ak19

Message:

Follows Dr Bainbridge's suggestion to prevent URL based calls to set-metadata and remove-meta metadataserver.pl operations. Split metadataaction.pm into modmetadataaction.pm and metadataaction.pm, shifting the methods that modify metadata (set and remove subroutines) into the first. Now GS3 sets an env var that will control whether the meta-modifying subroutines will be available when called. If the env var is set, then metadataaction.pm will include the modmetadataaction.pm file in the begin block. For GS2, it works as before, always including the meta modifying subroutines. Tested on Linux with the GS3 web doc editor vs calling metadataserver.pl to set metadata directly from a URL.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/GS2PerlConstructor.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/GS2PerlConstructor.java

@@ -324 +324 @@
         
         // Need to set QUERY_STRING and REQUEST_METHOD=GET in environment
+        // Also set GS3_AUTHENTICATED, to allow running metadata-server.pl with mod (set and remove) commands
         // http://www.cgi101.com/class/ch3/text.html
         String[] envvars = {
             "QUERY_STRING=" + this.query_string,
-            "REQUEST_METHOD=GET"
+            "REQUEST_METHOD=GET",
+            "GS3_AUTHENTICATED=true" // how do we set the env var without having to assign it a value?
         };