Changeset 31643 for main/trunk

Timestamp:

2017-05-02T20:33:29+12:00 (7 years ago)

Author:

ak19

Message:

Taskkill does not seem to be a route, but adding in code that works, but will kill any running perl on Windows, not just specific perl processes launched by GS.

File:

• main/trunk/gli/src/org/greenstone/gatherer/util/SafeProcess.java (modified) (5 diffs)

main/trunk/gli/src/org/greenstone/gatherer/util/SafeProcess.java

@@ -129 +129 @@
         }
         }
-    }
+    }   
 
     return prcs;
@@ -253 +253 @@
 
         if( this.forciblyTerminateProcess ) {
-        process.destroy(); // see runProcess() below        
+        process.destroy(); // see runProcess() below
+        //killAnyPerl();
         }
         process = null;
@@ -345 +346 @@
         log("*** Going to call process.destroy 2");
         process.destroy();
+        //killAnyPerl();
         log("*** Have called process.destroy 2");
         }
@@ -433 +435 @@
         log("*** Going to call process.destroy 1");
         process.destroy();
+        //killAnyPerl();
         log("*** Have called process.destroy 1");
         }
@@ -442 +445 @@
     }
 
-
+// stackoverflow.com/questions/1835885/send-ctrl-c-to-process-open-by-java  
+// (Taskkill command can kill all running perl. But what if we kill perl instances not launched by GS?)
+// stackoverflow.com/questions/912889/how-to-send-interrupt-key-sequence-to-a-java-process
+// Searching for: "forcibly terminate external process launched by Java on Windows" 
+static void killAnyPerl() {
+    if(!Utility.isWindows()) return;
+    
+    // only on Windows do we need to still kill perl despite process.destroy()
+    try{
+        Runtime.getRuntime().exec("taskkill /f /im perl.exe");      
+    } catch(Exception e) {
+        log("@@@ Exception attempting to stop perl " + e.getMessage(), e);      
+    }
+}
+    
 //******************** Inner class and interface definitions ********************//
 // Static inner classes can be instantiated without having to instantiate an object of the outer class first