Changeset 31716 for main/trunk/gli

Timestamp:

2017-05-30T21:23:20+12:00 (7 years ago)

Author:

ak19

Message:

Comments adjusted

File:

• main/trunk/gli/src/org/greenstone/gatherer/util/SafeProcess.java (modified) (2 diffs)

main/trunk/gli/src/org/greenstone/gatherer/util/SafeProcess.java

@@ -444 +444 @@
         // 2. basic waitFor the process to finish
         this.exitValue = process.waitFor();
-
+        
+        // 3. if we managed to get here, the process naturally terminated (wasn't interrupted):
         this.forciblyTerminateProcess = false;
     } catch(IOException ioe) {      
@@ -789 +790 @@
 // Kill signals, their names and numerical equivalents: http://www.faqs.org/qa/qa-831.html
 // https://stackoverflow.com/questions/8533377/why-child-process-still-alive-after-parent-process-was-killed-in-linux
-// Didn't work for when build scripts run from GLI: kill -TERM -pid
-// but the other suggestion did work: pkill -TERM -P pid did work
+// Works on Linux but not Mac when build scripts run from GLI: kill -TERM -pid
+// Works on Macs but not Linux: pkill -TERM -P pid
 // More reading:
 // https://superuser.com/questions/343031/sigterm-with-a-keyboard-shortcut