Changeset 31718 for main/trunk/gli/src/org/greenstone/gatherer/util/Readme_Using_SafeProcess.txt

Timestamp:

2017-05-31T18:05:11+12:00 (7 years ago)

Author:

ak19

Message:

Two more instances in GLI's Gatherer.java were using Java's Process instead of going through SafeProcess. I had a note in the tickets about this, but it was obscured by being an item in my todo list that was ticked off, because I hadn't originally intended to change these 2 instances to use SafeProcess, because SafeProcess didn't have a cancel feature back then. With the recent addition of the cancel feature, the changes became straightforward. Both remaining instances in Gatherer have been changed to use SafeProcess and it's tested on Linux. Updated the SafeProcess README.

File:

• main/trunk/gli/src/org/greenstone/gatherer/util/Readme_Using_SafeProcess.txt (modified) (2 diffs)

main/trunk/gli/src/org/greenstone/gatherer/util/Readme_Using_SafeProcess.txt

@@ -163 +163 @@
 
 
+All the runProcess() variants do a Process.waitFor(). This means all runProcess() variants block the primary thread, which is the thread in which they're executing, until the internal Process has completed.
 
 If you want to completely override the default behaviour of any of SafeProcess' iostream related worker threads (such as if you want to read a char at a time from the stderr stream and do something, instead of the default behaviour of reading a line at a time from it), then call this method.
@@ -756 +757 @@
     + src/org/greenstone/gatherer/gui/DownloadPane.java
     + src/org/greenstone/gatherer/util/GS3ServerThread.java
-    + 2 src/org/greenstone/gatherer/Gatherer.java [2 MORE but don't want to mess with those]
+    + 4 src/org/greenstone/gatherer/Gatherer.java [All 4 instances that used Process now go through SafeProcess instead]
     + 1 src/org/greenstone/gatherer/download/ServerInfoDialog.java
     + 2 src/org/greenstone/gatherer/greenstone/Classifiers.java