Changeset 31973 for main/trunk/greenstone2/perllib/IncrementalBuildUtils.pm

Timestamp:

2017-09-15T21:00:00+12:00 (7 years ago)

Author:

ak19

Message:

Related to previous commit which contained Dr Bainbridge's fix to bug noticed just now: IncrementalBuildUtils determines the PATH separator based on whether the OS name contained the win substring for Windows. However, Mac OS is called darwin and contains the win substring too, so Dr Bainbridge fixed the test to check for win as OS name prefix. This part of the code will need to be reworked in future, such as to use util's envvar_prepend and append functions instead of concatenating something that may already be on the PATH. Also, check for any existing methods to test if OS is windows or not to put it all in one place.

File:

• main/trunk/greenstone2/perllib/IncrementalBuildUtils.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/IncrementalBuildUtils.pm

@@ -79 +79 @@
 # Ensure the collection specific binaries are on the search path
 my $path_separator = ":";
-if($ENV{'GSDLOS'} =~ /^win/) {
+if($ENV{'GSDLOS'} =~ /^win/) { # beware to check that it starts with "win" for windows, since darwin also contains "win" but path separator for that should be :
   $path_separator = ";";
 }