Changeset 32078 for main/trunk

Timestamp:

2017-11-23T13:38:01+13:00 (6 years ago)

Author:

kjdon

Message:

only record deleted metadata changes if the field value was non empty. Otherwise if the user adds a field then deletes it, it will send off a delete meta request with an empty value, and something else will get deleted.

File:

• main/trunk/greenstone3/web/interfaces/default/js/documentedit_scripts_util.js (modified) (2 diffs)

main/trunk/greenstone3/web/interfaces/default/js/documentedit_scripts_util.js

@@ -336 +336 @@
   var metadataChanges = new Array();
   if (_deletedMetadata.length > 0) {
-    addCollectionToBuild(collection);
 
     for(var i = 0; i < _deletedMetadata.length; i++) {
@@ -353 +352 @@
       var valueCell = cells[1];
       var value = valueCell.getElementsByTagName("TEXTAREA")[0].value;
-      metadataChanges.push({type:'delete', docID:docID, name:name, value:value});
+    if (value.length) {
+        // check for non empty value, in case all they have done is add a field then deleted it.
+        metadataChanges.push({type:'delete', docID:docID, name:name, value:value});
+        addCollectionToBuild(collection);
+    }
       removeFromParent(currentRow);
     }