Changeset 32096 for main/trunk/greenstone2/perllib/plugins/ReadTextFile.pm

Timestamp:

2017-12-12T16:47:34+13:00 (6 years ago)

Author:

ak19

Message:

Marking all the uses of sysread() with a comment saying they're a candidate to use FileUtils::readUTF8File() in future, if thinking about each case beforehand has confirmed that the contents will indeed be UTF8.

File:

• main/trunk/greenstone2/perllib/plugins/ReadTextFile.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/plugins/ReadTextFile.pm

@@ -216 +216 @@
      
     if ($encoding eq "ascii") {
+    # The following file reading section is a candidate to use FileUtils::readUTF8File()
+    # in place of calling sysread() directly. But only if we can reason we'd be working with UTF8.
+    # ascii is UTF8, but it may become inefficient to treat ascii as utf8
+    
     # Replace file 'slurp' with faster implementation
     sysread(FILE, $$textref, -s FILE);