Changeset 32096 for main/trunk/greenstone2/perllib/servercontrol.pm

Timestamp:

2017-12-12T16:47:34+13:00 (6 years ago)

Author:

ak19

Message:

Marking all the uses of sysread() with a comment saying they're a candidate to use FileUtils::readUTF8File() in future, if thinking about each case beforehand has confirmed that the contents will indeed be UTF8.

File:

• main/trunk/greenstone2/perllib/servercontrol.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/servercontrol.pm

@@ -201 +201 @@
         # check the page content is as expected
         #my $resultstr = $response_content;
-        
+
+            # The following file reading section is a candidate to use FileUtils::readUTF8File()
+    # in place of calling sysread() directly. But only if we can reason we'd be working with UTF8
         open(FIN,"<$tmpfilename") or die "servercontrol.pm: Unable to open $tmpfilename to read ping response page...ERROR: $!\n";
         my $resultstr;