Changeset 32198 for gs2-extensions/pdf-box/trunk/java/perllib/plugins/PDFBoxConverter.pm

Timestamp:

2018-06-15T18:10:25+12:00 (6 years ago)

Author:

ak19

Message:

Fixing an issue with PDFBox to txt conversion, whereby PDFBox to txt conversion would produce text that's actually HTML in pre tags. Not sure if this issue was introduced during the recent commit upgrading the pdfbox version from 1.8.2 to 2.0.9, or whether it already existed. But fixing it now so that text conversion with PDFBox actually produces txt, while html conversion still produces the old cheap html without preserving any images in the src pdf.

File:

• gs2-extensions/pdf-box/trunk/java/perllib/plugins/PDFBoxConverter.pm (modified) (2 diffs)

gs2-extensions/pdf-box/trunk/java/perllib/plugins/PDFBoxConverter.pm

@@ -127 +127 @@
     my $pbajar = &FileUtils::filenameConcatenate($gextpb_home,"lib","java","pdfbox-app.jar");
     my $java = &util::get_java_command();
-    my $launch_cmd = "$java -cp \"$pbajar\" -Dline.separator=\"<br />\" org.apache.pdfbox.tools.ExtractText";
-    
-    $self->{'pdfbox_launch_cmd'} = $launch_cmd;
+    $self->{'pdfbox_txt_launch_cmd'} = "$java -cp \"$pbajar\" org.apache.pdfbox.tools.ExtractText";
+    $self->{'pdfbox_html_launch_cmd'} = "$java -cp \"$pbajar\" -Dline.separator=\"<br />\" org.apache.pdfbox.tools.ExtractText";
     #$self->{'pdfbox_img_launch_cmd'} = "java -cp \"$pbajar\" org.apache.pdfbox.tools.PDFToImage"; # pdfbox 2.09 cmd for converting each PDF page to an image (gif, jpg, png)
     # Now: use this cmd to launch our new custom PDFBox class (PDFBoxToImagesAndText.java) to convert each PDF page into an image (gif, jpg, png)
@@ -244 +243 @@
     
     } else { # html or text
-    $convert_cmd = $self->{'pdfbox_launch_cmd'};
-    $convert_cmd .= " -html" if ($target_file_type eq "html");
+    
+    if ($target_file_type eq "html") {
+        $convert_cmd = $self->{'pdfbox_html_launch_cmd'};
+        $convert_cmd .= " -html" if ($target_file_type eq "html");
+    } else {
+        $convert_cmd = $self->{'pdfbox_txt_launch_cmd'};
+    }
     $convert_cmd .= " \"$source_file_full_path\" \"$target_file_path\"";
     }