Changeset 32317 for gs2-extensions/open-office/trunk/src/perllib/plugins/OpenOfficeConverter.pm

Timestamp:

2018-07-30T20:34:58+12:00 (6 years ago)

Author:

ak19

Message:

Basic updates to OpenOffice extension: 1. BasePlugin is now BaseImporter 2. Warnings notified a change from single minus prefix to accept and headless arguments, to double minus prefix. Still haven't resolved 2 bugs: GLI will get stuck when launching when the open office ext is included and if this gets stuck. Hard to track down so far, but this ext's jodconverter jar gets stuck running from the cmdline on these occasions too. And haven't resolved how to get jodconverter to convert (word) docs that contain images to HTML without always embedding the images inline as base64. jodconverter doesn't take the same names for options as the soffice commands it calls. Jodconverter's cmdline usage display is either not complete or the options are very limited.

File:

• gs2-extensions/open-office/trunk/src/perllib/plugins/OpenOfficeConverter.pm (modified) (3 diffs)

gs2-extensions/open-office/trunk/src/perllib/plugins/OpenOfficeConverter.pm

@@ -72 +72 @@
         }
         
-        #my $cmd = "soffice -headless 2>&1"; # for linux and mac
-        my $cmd = "soffice \"-accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" -headless 2>&1"; # for linux and mac
+        #my $cmd = "soffice --headless 2>&1"; # for linux and mac
+        my $cmd = "soffice \"--accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" --headless 2>&1"; # for linux and mac
         my $status = 0;
 
         # No more JODCONVERTER_PORT env var: the port that jodconverter uses is now the
         # same as SOFFICE_PORT, because the 2 are meant to communicate on the same port.
-        # The default port that jodconverter expects OO to listen on is 8100, so we try that.
+        # The default port that jodconverter expects OO (OpenOffice/libreoffice/soffice/staroffice) to listen on is 8100, so we try that.
         if ($ENV{'GSDLOS'} =~ m/^windows$/) {       
         
@@ -100 +100 @@
         $status = system("which soffice >nul 2>&1"); # which.exe should be in bin/windows
         if ($status == 0) {
-            $cmd = "start \"soffice process\" soffice \"-accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" -headless 2>&1";
+            $cmd = "start \"soffice process\" soffice \"--accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" --headless 2>&1";
             $cmd .= " >nul";
             #print STDERR "***** Tried to start-up OpenOffice with:\n$cmd\n";           
@@ -179 +179 @@
 
     my $launch_cmd = "soffice";
-    $launch_cmd .= " \"-accept=socket,host=localhost,port=$oo_port;urp;StarOffice.ServiceManager\"";
-    $launch_cmd .= " -headless";
+    $launch_cmd .= " \"--accept=socket,host=localhost,port=$oo_port;urp;StarOffice.ServiceManager\"";
+    $launch_cmd .= " --headless";
     $self->{'openoffice_launch_cmd'} = $launch_cmd;
     }