Changeset 32319 for main/trunk/greenstone3/src

Timestamp:

2018-07-31T10:01:09+12:00 (6 years ago)

Author:

kjdon

Message:

Georgy was having issues with setNodeText - the child node to be removed was not there causing null pointer exception. concurrent access issue? Now we copy the node before setting the text - don't want to be modifying the underlying list as two thread may be trying to modify it at the same time.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/DisplayItemUtil.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/DisplayItemUtil.java

@@ -88 +88 @@
         String value = getTextString(new_m.getAttribute(GSXML.KEY_ATT), lang, new_m.getAttribute(GSXML.DICTIONARY_ATT), class_loader);
         if (value != null) {
+          // copy the node now. Don't want to be modifying the underlying list as can lead to concurrent access problems.
+          new_m = (Element)doc.importNode(new_m, true);
           GSXML.setNodeText(new_m, value);
         }