Changeset 32323

Timestamp:

2018-08-06T19:38:44+12:00 (6 years ago)

Author:

ak19

Message:

1. Dr Bainbridge fixed the way OpenOfficeConverter launched soffice in headless mode: it was incorrectly doing the 2 greater than ampersand 1 (redirecting stderr to stdout) before redirecting to /dev/null (and nul on windows). It has to be redirecting to /dev/null (and nul) before doing 2 greater than ampersand 1. The error had resulted in GLI failing to launch properly, with the call to pluginfo on the entire pluginlist blocking. SafeProcess was getting no data at all on the pluginfo process' stdout, not even eof/eos, so the BufferedReader.readLine() (and any read()) blocked resulting in that InputStreamGobbler.join() call not terminating.

Location:

gs2-extensions/open-office/trunk

Files:

• open-office-java.tar.gz (modified) ( previous)
• open-office-java.zip (modified) ( previous)
• src/perllib/plugins/OpenOfficeConverter.pm (modified) (3 diffs)

gs2-extensions/open-office/trunk/src/perllib/plugins/OpenOfficeConverter.pm

@@ -73 +73 @@
         
         #my $cmd = "soffice --headless 2>&1"; # for linux and mac
-        my $cmd = "soffice \"--accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" --headless 2>&1"; # for linux and mac
+        my $cmd = "soffice \"--accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" --headless"; # basic shared command
         my $status = 0;
 
@@ -100 +100 @@
         $status = system("which soffice >nul 2>&1"); # which.exe should be in bin/windows
         if ($status == 0) {
-            $cmd = "start \"soffice process\" soffice \"--accept=socket,host=$ENV{'SOFFICE_HOST'},port=$ENV{'SOFFICE_PORT'};urp;StarOffice.ServiceManager\" --headless 2>&1";
-            $cmd .= " >nul";
+            $cmd = "start \"soffice process\" $cmd >nul 2>&1"; # order of >nul and 2>&1 matters, see below
             #print STDERR "***** Tried to start-up OpenOffice with:\n$cmd\n";           
         }
@@ -110 +109 @@
         # automatically puts it in the background).  
         # For Unix putting it in the background needs to be done 
-        # explicitly
-
-        $cmd .= " >/dev/null &";
-        }
+        # explicitly by appending & to the end
+
+        # IMPORTANT! When redirecting output from 2>&1 to a file or null, >/dev/null (or >out.txt) should come BEFORE 2>&1 
+        # i.e. $some_cmd >out.txt 2>&1 and likewise $some_cmd >/dev/null 2>&1
+        # Doing it in the wrong order further causes problems with SafeProcess when GLI starts up and calls pluginfo on the pluginslist:
+        # SafeProcess blocks forever on read() from stdout of the process running pluginfo, because there's never data including no eof/eos
+        # on the process' stdout when running this command in the wrong order.
+        $cmd .=  " >/dev/null 2>&1 &";
+        }
+
+        #print STDERR "@@@@ running: $cmd\n";
         
         $status = system($cmd) if ($status == 0);