Changeset 32448 for main/trunk/greenstone3/src/java/org/greenstone/gsdl3/action/GeneralAction.java

Timestamp:

2018-09-13T14:05:59+12:00 (6 years ago)

Author:

kjdon

Message:

params class changed, now returns false by default for shouldsave. so don't need to add any that we don't want saving in the session. turned hard coded strings into static string variables

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/action/GeneralAction.java (modified) (3 diffs)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/action/GeneralAction.java

@@ -27 +27 @@
 {
 
+  public static final String CONFIG_CHANGE_NAME_ARG = "configChangeName";
+  public static final String CONFIG_CHANGE_VALUE_ARG = "configChangeValue";
+  
     /** process a request */
     public Node process(Node message_node)
@@ -48 +51 @@
         HashMap<String, Serializable> params = GSXML.extractParams(cgi_param_list, false);
 
-        if (params.get("configChangeName") != null && params.get("configChangeValue") != null)
-        {
-            String optionName = (String) params.get("configChangeName");
-            String optionValue = (String) params.get("configChangeValue");
+        if (params.get(CONFIG_CHANGE_NAME_ARG) != null && params.get(CONFIG_CHANGE_VALUE_ARG) != null)
+        {
+            String optionName = (String) params.get(CONFIG_CHANGE_NAME_ARG);
+            String optionValue = (String) params.get(CONFIG_CHANGE_VALUE_ARG);
 
             changeConfig(optionName, optionValue);
@@ -100 +103 @@
             Element param_list = null;
             // add in the service params - except the ones only used by the action
-            HashMap service_params = (HashMap) params.get("s1");
+            HashMap service_params = (HashMap) params.get(GSParams.SERVICE_PREFIX);
             if (service_params != null)
             {