Changeset 32563 for main/trunk/greenstone2/perllib/plugouts/BasePlugout.pm

Timestamp:

2018-11-02T19:07:16+13:00 (5 years ago)

Author:

ak19

Message:

1. Overhaul of GreenstoneSQLPlugs to handle removeold and incremental delete correctly. And now code also automatically handles 'non-incremental delete' (see mention in ArchivesInfPlugin). The new version no longer does lazy loading for getting the sql db connection in the GS SQL Plugin, as now the connection needs to be active since the start of the plugin to run SQL delete statements on remove_old. So the db connection code for the GS SQL plugin has moved back into its init() method. Lots of changes to gssql.pm (and some flow on effects to the GS SQL Plugout) as when database tables exist and need to be created have changed. 2. Undoing most of the changes of changeset 32555 since we're doing incremental delete and removeold differently and in the correct way now when using the GreenstoneSQLPlugs.

File:

• main/trunk/greenstone2/perllib/plugouts/BasePlugout.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/plugouts/BasePlugout.pm

@@ -347 +347 @@
 }
 
-# GreenstoneSQLPlugout needs to know whether we're doing removeold or not
-sub set_incremental_options {
-    my $self= shift (@_);
-    my ($removeold, $keepold, $incremental, $incremental_mode) = @_;
-    
-    $self->{'removeold'}        = $removeold;
-    $self->{'keepold'}          = $keepold;
-    $self->{'incremental'}      = $incremental;
-    $self->{'incremental_mode'} = $incremental_mode;
-}
 
 # OIDtype may be "hash" or "hash_on_full_filename" or "incremental" or "filename" or "dirname" or "full_filename" or "assigned"