Changeset 32565 for main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm

Timestamp:

2018-11-02T20:51:09+13:00 (5 years ago)

Author:

ak19

Message:

I think this is a bugfix to plugin.pm::remove_some(): when processing files to delete on deletion/reindexing, it would return after the first successful remove_one(). This wasn't a noticeable problem in the past since no plugin had a real need for implementing remove_one(). But now GS SQLPlugin does remove_one() in earnest, we need all the docs marked for deletion to be processed.

File:

• main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm

@@ -228 +228 @@
     my $gs_sql = $self->{'gs_sql'} || return 0; # couldn't make the connection or no db etc
     if(scalar @$oids > 1) {
-    print STDERR "TODO: We now have reason to optimise GreenstoneSQLPlugin::remove_one() by using prepare and execute.\n";
+    print STDERR "TODO: We now have reason to optimise GreenstoneSQLPlugin::remove_one() by using dbi::prepare() + dbi::execute() instead of dbi::do().\n";
     }