Changeset 32585

Timestamp:

2018-11-08T17:44:19+13:00 (5 years ago)

Author:

ak19

Message:

Super call in destructor. More important if subclassing.

File:

• main/trunk/greenstone2/perllib/gssql.pm (modified) (3 diffs)

main/trunk/greenstone2/perllib/gssql.pm

@@ -43 +43 @@
 
 # TODO: drop table if exists and create table if exists are available in MySQL. Use those cmds
-# instead of always first checking for existence ourselves?
+# instead of always first checking for existence ourselves? Only when subclassing to specific
+# mysql class.
 ##############################
 
@@ -139 +140 @@
 sub DESTROY {
     my $self = shift;
-
+    
     if (${^GLOBAL_PHASE} eq 'DESTRUCT') {
     
@@ -165 +166 @@
     return;
     }
+
+    # "Always include a call to $self->SUPER::DESTROY in our destructors (even if we don't yet have any base/parent classes). (p. 145)"
+    # Superclass and destroy, call to SUPER: https://www.perlmonks.org/?node_id=879920
+    # also covers multiple-inheritance (MI)    
+    $self->SUPER::DESTROY if $self->can("SUPER::DESTROY");
 
 }