Changeset 32610

Timestamp:

2018-11-16T17:24:55+13:00 (5 years ago)

Author:

ak19

Message:

The solene_src object does not appear to be used by either lucene or solr. GS2LuceneSearch declares and manages its own lucene_src object (a GS2LuceneQuery object). solene_src may be removed hereafter from SharedSoleneGS2FieldSearch. But for now, writing a cleanUp method skeleton so that any cleaning up of its Query object will be called in there.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/SharedSoleneGS2FieldSearch.java (modified) (2 diffs)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/SharedSoleneGS2FieldSearch.java

@@ -44 +44 @@
   static Logger logger = Logger.getLogger(org.greenstone.gsdl3.service.SharedSoleneGS2FieldSearch.class.getName());
 
+  // Neither lucene nor solr appear to use solene_src. GS2LuceneQuery has its own object, lucene_src
   protected SharedSoleneQuery solene_src = null;
   protected String default_sort = "";
@@ -61 +62 @@
     }
 
+    public void cleanUp()
+    {
+        super.cleanUp();
+        
+        if(this.solene_src != null) {
+            this.solene_src.cleanUp();
+        }
+    }
+    
     /** configure this service */
     public boolean configure(Element info, Element extra_info)