Changeset 32637

Show
Ignore:
Timestamp:
27.11.2018 14:24:20 (2 weeks ago)
Author:
ak19
Message:

1. Returning to the original windows iconv.zip. 2. Making and documenting the final change to get the original windows iconv.zip to compile with VS2017 (or is it VS14/2015) without errors.

Location:
main/trunk/greenstone2/common-src/indexers/packages/windows/iconv
Files:
2 modified

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone2/common-src/indexers/packages/windows/iconv/GS-README-VS14-VS2015-AND-LATER.txt

    r32632 r32637  
    1010 
    1111 
    12 1. Libiconv 1.11 appears to be the last version of the package that can be compiled with Visual Studio. 
     12[ 
     13NO NEED FOR STEP 1 
     14X 1. Libiconv 1.11 appears to be the last version of the package that can be compiled with Visual Studio. 
    1315Subsequent versions require Mingw and/or Cygwin and won't work easily with our existing GS compile workflow. 
    1416 
     
    1921Then I renamed the untarred version from libiconv-1.11 to iconv 
    2022and finally I zipped it up to produce iconv.zip. 
    21  
     23] 
    2224 
    23252. In the Makefile.msvc files inside gs-libiconv 1.11 that are listed below, 
     
    7072 
    7173 
     744. stdbool.h redefinition of bool 
     75 
     76- The solution wasn't: http://www.cplusplus.com/forum/beginner/72957/ 
     77(and which issue produced the flow on errors at https://lists.gnu.org/archive/html/bug-gnu-libiconv/2007-07/msg00002.html) 
     78 
     79- The solution was indicated at: https://github.com/chansen/p5-time-moment/issues/12 
     80That new VS compilers had their own stdbool.h where bool was typedefed to some other type with a different size in memory. 
     81So we have to use this stdbool.had 
     82 
     83My solution was therefore to get rid of iconv/windows/stdbool.h for the iconv-VS14+ version, 
     84to let it find the iconv in VS14+ instead. 
     85So I renamed iconv/windows/stdbool.h to iconv/windows/stdbool.unusable_for_VS14plus 
     86     
    7287 
    7388INFORMATIVE LINKS THAT WEREN'T RELEVANT AT THE TIME OR TO SOLVING THE ABOVE PROBLEMS: