Changeset 32637 for main

Timestamp:

2018-11-27T14:24:20+13:00 (5 years ago)

Author:

ak19

Message:

1. Returning to the original windows iconv.zip. 2. Making and documenting the final change to get the original windows iconv.zip to compile with VS2017 (or is it VS14/2015) without errors.

Location:

main/trunk/greenstone2/common-src/indexers/packages/windows/iconv

Files:

• GS-README-VS14-VS2015-AND-LATER.txt (modified) (3 diffs)
• iconv.zip (modified) ( previous)

main/trunk/greenstone2/common-src/indexers/packages/windows/iconv/GS-README-VS14-VS2015-AND-LATER.txt

@@ -10 +10 @@
 
 
-1. Libiconv 1.11 appears to be the last version of the package that can be compiled with Visual Studio.
+[
+NO NEED FOR STEP 1
+X 1. Libiconv 1.11 appears to be the last version of the package that can be compiled with Visual Studio.
 Subsequent versions require Mingw and/or Cygwin and won't work easily with our existing GS compile workflow.
 
@@ -19 +21 @@
 Then I renamed the untarred version from libiconv-1.11 to iconv
 and finally I zipped it up to produce iconv.zip.
-
+]
 
 2. In the Makefile.msvc files inside gs-libiconv 1.11 that are listed below,
@@ -70 +72 @@
 
 
+4. stdbool.h redefinition of bool
+
+- The solution wasn't: http://www.cplusplus.com/forum/beginner/72957/
+(and which issue produced the flow on errors at https://lists.gnu.org/archive/html/bug-gnu-libiconv/2007-07/msg00002.html)
+
+- The solution was indicated at: https://github.com/chansen/p5-time-moment/issues/12
+That new VS compilers had their own stdbool.h where bool was typedefed to some other type with a different size in memory.
+So we have to use this stdbool.had
+
+My solution was therefore to get rid of iconv/windows/stdbool.h for the iconv-VS14+ version,
+to let it find the iconv in VS14+ instead.
+So I renamed iconv/windows/stdbool.h to iconv/windows/stdbool.unusable_for_VS14plus
+    
 
 INFORMATIVE LINKS THAT WEREN'T RELEVANT AT THE TIME OR TO SOLVING THE ABOVE PROBLEMS: