Changeset 32699

Timestamp:

2018-12-16T22:43:31+13:00 (5 years ago)

Author:

ak19

Message:

This fixes another EDT (Event Dispatch Thread) access violation instance where the opening a collection dialog despite being GUI stuff was not done in the Swing EDT thread. The AssertJ Swing test I'm working on at present detected this and fixing it here got me through the test as well.

File:

• main/trunk/gli/src/org/greenstone/gatherer/gui/GUIManager.java (modified) (3 diffs)

main/trunk/gli/src/org/greenstone/gatherer/gui/GUIManager.java

@@ -204 +204 @@
     }
     else if (esrc == menu_bar.file_open) {
-        new OpenCollectionTask().start();
+        //new OpenCollectionTask().start(); // will cause an EDT access violation exception
+        // since the GUI stuff of opening a collection is not done in a Swing thread
+        SwingUtilities.invokeLater(new OpenCollectionTask());
     }
     else if (esrc == menu_bar.file_options) {
@@ -379 +381 @@
         menu_bar = new MenuBar(new MenuListenerImpl());
             menu_bar.setComponentOrientation(Dictionary.getOrientation());
-
+        
         //feedback changes
         //content_pane.add(menu_bar, BorderLayout.NORTH);
@@ -935 +937 @@
 
     private class OpenCollectionTask
-        extends Thread
+    implements Runnable //extends Thread -> If this extends Thread, it will cause an EDT access
+           // violation since the GUI stuff in run() is not done in the Swing Event Dispatch Thread/EDT.
     {
     public void run()