Changeset 32704

Timestamp:

2018-12-17T22:45:42+13:00 (5 years ago)

Author:

ak19

Message:

GLI GUI testing with AssertJ Swing discovered a NullPointerException after a sequence of events, reproduced when the same event sequence was repeated manually with GLI: when user pref mode is changed to librarian, then lucene-demo collection opened and closed, then collection pinky created, closed and deleted, and lucene-demo collection exported to GS METS, and then finally the user pref mode changed back to expert. This triggered the NullPointerException in cdm first in plugin_manager, and when fixed, in the next line of classifier_manager. So have corrected all such cases.

File:

• main/trunk/gli/src/org/greenstone/gatherer/cdm/CollectionDesignManager.java (modified) (1 diff)

main/trunk/gli/src/org/greenstone/gatherer/cdm/CollectionDesignManager.java

@@ -189 +189 @@
      */
     public void modeChanged(int mode) {
-    plugin_manager.modeChanged(mode);
-    classifier_manager.modeChanged(mode);
-    subcollection_manager.modeChanged(mode);
-    supercollection_manager.modeChanged(mode);
-    //format_manager.modeChanged(mode);
-    index_manager.modeChanged(mode);
-    translation_manager.modeChanged(mode);
-    general_manager.modeChanged(mode);
-    language_manager.modeChanged(mode);
-    searchmetadata_manager.modeChanged(mode);
-    depositormetadata_manager.modeChanged(mode);
+    if (plugin_manager != null) plugin_manager.modeChanged(mode);   
+    if(classifier_manager != null) classifier_manager.modeChanged(mode);
+    if(subcollection_manager != null) subcollection_manager.modeChanged(mode);
+    if(supercollection_manager != null) supercollection_manager.modeChanged(mode);
+    //if(format_manager != null) format_manager.modeChanged(mode);
+    if(index_manager != null) index_manager.modeChanged(mode);
+    if(translation_manager != null) translation_manager.modeChanged(mode);
+    if(general_manager != null) general_manager.modeChanged(mode);
+    if(language_manager != null) language_manager.modeChanged(mode);
+    if(searchmetadata_manager != null) searchmetadata_manager.modeChanged(mode);
+    if(depositormetadata_manager != null) depositormetadata_manager.modeChanged(mode);
     }