Changeset 32809

Timestamp:

2019-02-25T16:59:01+13:00 (5 years ago)

Author:

ak19

Message:

Fix to bug that broke OAIDownload tutorial: on Windows, ECONNRESET is not error. This needs to be dealt with in 2 places in WgetDownload.pm, but only once part of the code had the latest version until now. In the remaining spot ECONNRESET was still assumed to be an error even though this happens as a matter of course on Windows. Because of it being dealt with as an error, OAIDownload terminates getting dealing with that oai file before it's actually finished and the gi.Sourcedoc meta no longer ends up in the file. Still another bug remaining in this tutorial.

File:

• main/trunk/greenstone2/perllib/downloaders/WgetDownload.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/downloaders/WgetDownload.pm

@@ -716 +716 @@
             $full_text .= $line;
         } else { # error or EOF
-            if(!defined $len) { # error reading
-            #print STDERR "WgetDownload: Error reading from child stream: $!\n";
-            $error = 1;
-            }
-             if(!defined $len) {
+             if(!defined $len) { # could be an error reading    
+              # On Windows, the socket ends up forcibly closed on the "other" side. It's just the way it's implemented 
+              # on Windows when using sockets to our child process' iostreams. So $len not being defined is not an error in that case. Refer to
+              # https://stackoverflow.com/questions/16675950/perl-select-returning-undef-on-sysread-when-using-windows-ipcopen3-and-ios/16676271
               if(!$!{ECONNRESET}) { # anything other ECONNRESET error means it's a real case of undefined $len being an error
-                #print STDERR "WgetDownload: Error reading from child stream: $!\n";                
+                print STDERR "WgetDownload: Error reading from child stream: $!\n";
+                # SHOULD THIS 'die "errmsg";' instead? - no, sockets may need closing
                 $error = 1;
-              } else { # the error code is ECONNRESET, and it's not an error, despite $len being undefined. 
-                       # Happens on Windows when using sockets to a child process' iostreams
+              } else { # $! contains message "An existing connection was forcibly closed by remote host" where "remote" is a reference to the sockets to our wget child process,
+                    # NOT to the remote web server we're downloading from. In such a case, the error code is ECONNRESET, and it's not an error, despite $len being undefined.
+                    # Happens on Windows when using sockets to a child process' iostreams
                 #print STDERR "WgetDownload: wget finished\n";
               }