Changeset 32849 for main/trunk/greenstone2

Timestamp:

2019-03-04T15:49:22+13:00 (5 years ago)

Author:

ak19

Message:

Undoing 32841 afgter discussion with Dr Bainbridge who worked out that forcing metamode to be written out as override has no meaning in doc.xml files.

File:

• main/trunk/greenstone2/perllib/cgiactions/modmetadataaction.pm (modified) (2 diffs)

main/trunk/greenstone2/perllib/cgiactions/modmetadataaction.pm

@@ -859 +859 @@
                 $attrHash->{'_content'} = $metavalue;
                 
-                print STDERR "**** WARNING, NOT SURE IF IT'S ALWAYS THE RIGHT TO DO, but setting metamode to override as requested";
-                
-                $attrHash->{'mode'} = $metamode; # if it was set to accumulate the first time this meta was added, make sure it is set to override now
+                # until we have clearly determined the role of metamode in doc.xml files (we know what it means in import/metadata.xml files)
+                # we're not setting metamode to override here.
                 
                 # Don't want it to wipe out any other pieces of metadata
@@ -873 +872 @@
                 $attrHash->{'_content'} = $metavalue;
                 
-                print STDERR "**** WARNING, NOT SURE IF IT'S ALWAYS THE RIGHT TO DO, but setting metamode to override as requested";
-                $attrHash->{'mode'} = $metamode; # if it was set to accumulate the first time this meta was added, make sure it is set to override now
+                # until we have clearly determined the role of metamode in doc.xml files (we know what it means in import/metadata.xml files)
+                # we're not setting metamode to override here.
                 
                 $parser->{'parameters'}->{'metamode'} = "done";