Changeset 33072 for main

Timestamp:

2019-05-14T10:13:30+12:00 (5 years ago)

Author:

kjdon

Message:

DeleteItem service had never been implemented, only DeleteItems, despite the advertising for the service. Commenting DeleteItem code out so that its obvious it hasn't been implemented. Would we want it? easy enough to call DeleteItems... should just delete it next time?

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/BerryBasket.java (modified) (3 diffs)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/BerryBasket.java

@@ -64 +64 @@
     protected static final String DELETE_ITEMS_SERVICE = "DeleteItems";
     protected static final String SEND_MAIL_SERVICE = "SendMail";
-    protected static final String DELETE_ITEM_SERVICE = "DeleteItem";
+    //protected static final String DELETE_ITEM_SERVICE = "DeleteItem";
 
   // for AddItem
@@ -151 +151 @@
 
         // set up short_service_info_ - for now just has name and type
-        Element deleteone_service = this.desc_doc.createElement(GSXML.SERVICE_ELEM);
-        deleteone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
-        deleteone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
-        this.short_service_info.appendChild(deleteone_service);
+        // Element deleteone_service = this.desc_doc.createElement(GSXML.SERVICE_ELEM);
+        // deleteone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
+        // deleteone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
+        // this.short_service_info.appendChild(deleteone_service);
 
         // set up short_service_info_ - for now just has name and type
@@ -227 +227 @@
         }
 
-        if (service_id.equals(DELETE_ITEM_SERVICE))
-        {
-
-            Element delone_service = doc.createElement(GSXML.SERVICE_ELEM);
-            delone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
-            delone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
-            return delone_service;
-        }
+        // if (service_id.equals(DELETE_ITEM_SERVICE))
+        // {
+
+        //  Element delone_service = doc.createElement(GSXML.SERVICE_ELEM);
+        //  delone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
+        //  delone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
+        //  return delone_service;
+        // }
 
         if (service_id.equals(SEND_MAIL_SERVICE))