Changeset 33290 for main

Show
Ignore:
Timestamp:
02.07.2019 21:09:46 (8 weeks ago)
Author:
wy59
Message:

Minor cleanup

Files:
1 modified

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone3/web/interfaces/default/js/map-scripts.js

    r33289 r33290  
    437437} 
    438438 
    439 // In order for fitBounds to work out a non-zero bounds, have to use visibility, not display when hiding/showing the map. 
     439// Refer to https://developers.google.com/maps/documentation/javascript/reference/map#Map.fitBounds 
     440// In order for fitBounds() to work out a non-zero bounds, have to use visibility, not display when hiding/showing the map. 
    440441// AND should not set height to 0px when using visibility hidden. But not setting height to 0 means an invisible map takes up space. 
    441442// In order for the resulting invisible map, that still takes up space, to not break the flow of the visible items 
    442443// on the page, need to swap map between position relative when map visible versus position absolute when the map is hidden. 
    443 // https://developers.google.com/maps/documentation/javascript/reference/map#Map.fitBounds 
    444444function showMap(callingFunction) { 
    445445     
     
    904904            showMap("httpMapBrowseRequest"); 
    905905             
    906             //var jsonNodesStr = "";             
    907906            for(var i = 0; i < jsonNodes.length; i++) 
    908907            { 
     
    911910                _docList.ids.push(doc.nodeID); 
    912911     
    913                 //$("#div"+doc.nodeID).attr("data-gps-map-json", JSON.stringify(jsonNodes[i])); 
    914                 //jsonNodesStr += JSON.stringify(jsonNodes[i]); // can't do this after createOverlayItems, as we get cyclical ref error 
    915912                var options = { 
    916913                    "mainDoc": true // TODO: should this be true or false???