Changeset 33750 for main

Timestamp:

2019-12-04T16:47:25+13:00 (4 years ago)

Author:

ak19

Message:

Fixed a NullPointerException without stacktrace, noticed with dlheritage resulting in Untitled docs under author Young, Amanda. The only further log information was that there had been an InvocationTargetException when processDocumentMetadataRetrieve (a processService) was called on a subclass (GS2SolrRetrieve). The log also mentioned an ERROR:t ServiceRack.process() adding in an error element. The SO page at ​https://stackoverflow.com/questions/2411487/nullpointerexception-in-java-with-no-stacktrace had one answer that was relevant, which was that when the same Null ptr exception occurs multiple times, logger no longer prints out the full stack trace and to look in earlier parts of the log. Looking in an earlier log file, allowed me to find out that the Null ptr exception happened in AbstractGS2DocumentRetrieve.java where metas was null and therefore metas.length resulted in the exception. Fixing this appears to have fixed everything to do with this in dlheritage.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/AbstractGS2DocumentRetrieve.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/AbstractGS2DocumentRetrieve.java

@@ -367 +367 @@
       // look for metadata refs
       String [] metas = StringUtils.substringsBetween(val, "[", "]");
-      for (int i=0; i<metas.length; i++) {
-        String meta = metas[i];
-        String meta_val;
-        // hack for parent(Top). gs2 had lots of other modifiers, but is this the only one that was used in
-        // metadata values??
-        if (meta.startsWith("parent(Top):")) {
-          String nmeta = meta.substring(12); // or 13?
-          String root_id = OID.getTop(oid);
-          DBInfo root_info = this.coll_db.getInfo(root_id);
-          meta_val = root_info.getInfo(nmeta);
-        } else {
-          meta_val = this_info.getInfo(meta);
-        }
-        if (!meta_val.equals("")) {
-          val = StringUtils.replace(val,"["+meta+"]",meta_val);
-        }
+      if(metas != null) {
+          for (int i=0; i<metas.length; i++) {
+          String meta = metas[i];
+          String meta_val;
+          // hack for parent(Top). gs2 had lots of other modifiers, but is this the only one that was used in
+          // metadata values??
+          if (meta.startsWith("parent(Top):")) {
+              String nmeta = meta.substring(12); // or 13?
+              String root_id = OID.getTop(oid);
+              DBInfo root_info = this.coll_db.getInfo(root_id);
+              meta_val = root_info.getInfo(nmeta);
+          } else {
+              meta_val = this_info.getInfo(meta);
+          }
+          if (!meta_val.equals("")) {
+              val = StringUtils.replace(val,"["+meta+"]",meta_val);
+          }
+          }
+      } else {
+          logger.info("@@@@ metas was null. Using val: " + val);
       }
       values.set(j,val);