Changeset 33934

Timestamp:

2020-02-16T17:34:29+13:00 (4 years ago)

Author:

davidb

Message:

Removal of static code block calling ancient/deprecated static runFinalizers method; See comment in file for more details. Leaving it's use of finalize(), however this is also considered questionable practice. If needed, a clearer solution might be to be things on addShutdownHook() A could of useful pages on this are: ​https://stackoverflow.com/questions/20829228/shutdown-hook-vs-finalizer-method ​https://stackoverflow.com/questions/26271464/implementation-of-addshutdownhook

File:

• main/trunk/greenstone3/src/packages/javagdbm/java/au/com/pharos/gdbm/GdbmFile.java (modified) (1 diff)

main/trunk/greenstone3/src/packages/javagdbm/java/au/com/pharos/gdbm/GdbmFile.java

@@ -158 +158 @@
      * XXX: Unfortunately, anybody else can turn this off again: it
      * would be nice if there was a way to avoid this. */
+
+     // ****
+     // Greenstone modifiction: runFinalizersOnExit() has been deprecated
+     // since Java 1.2, and was finally removed in Java 1.9
+     // The method was always "inherently unsafe" (Sun developers)
+     // "Calling this method may result in finalizers being called on live objects 
+     //  while other threads are concurrently manipulating those objects, 
+     //  resulting in erratic behavior or deadlock.
+     //
+     // => Decision made to remove the static code block that calls this
+
+     /*
     static {
     System.runFinalizersOnExit(true);
     }
-
+    */