Space-proofing gli

[oranfry]

Discovered under ubuntu linux. The gli java code has trouble with spaces in install paths. I installed Greenstone to <tt>/home/oranfry/Desktop/Green Stone Two</tt> and ran gli:

oranfry@bedrock:~/Desktop/Green Stone Two/gli$ ./gli.sh 

Greenstone Librarian Interface (GLI)
Copyright (C) 2006, New Zealand Digital Library Project, University Of Waikato
GLI comes with ABSOLUTELY NO WARRANTY; for details see LICENSE.txt
This is free software, and you are welcome to redistribute it

Greenstone version found: 2
Checking GSDL2: /home/oranfry/Desktop/Green Stone Two
Your environment has successfully been set up to run Greenstone
Adding in executable path for apache-httpd

GSDLHOME is: /home/oranfry/Desktop/Green Stone Two

Perl:
/usr/bin/perl

Java:
/home/oranfry/Desktop/Green Stone Two/packages/jre/bin/java



ImageMagick bundled with Greenstone will be used, if you wish to use
the version installed on your system (if any) please go to
/home/oranfry/Desktop/Green Stone Two/bin/linux and rename
the folder called imagemagick to something else.


Running the Greenstone Librarian Interface...
Version: 2s2009.04.22

java.io.IOException: Cannot run program "/home/oranfry/Desktop/Green":
java.io.IOException: error=2, No such file or directory
	at java.lang.ProcessBuilder.start(Unknown Source)
	at java.lang.Runtime.exec(Unknown Source)
	at java.lang.Runtime.exec(Unknown Source)
	at java.lang.Runtime.exec(Unknown Source)
	at org.greenstone.gatherer.Gatherer$ExternalApplication.run(Gatherer.java:1126)
Caused by: java.io.IOException: java.io.IOException: error=2, No such file or directory
	at java.lang.UNIXProcess.<init>(Unknown Source)
	at java.lang.ProcessImpl.start(Unknown Source)
	... 5 more

A minute passes and a dialog box appears, plus more output to the console:

User cache dir: /home/oranfry/.gli/cache/
Done!

The dialog box said: "The greenstone local library server has not responded to the automatic close command for sixty seconds. Do you wish to wait for another minute?" Clicking "no" brings up gli as normal.

It looks like gli tried to execute a command to stop the server if it was running, the command failed because of spaces in the install path, and as a result caused a 60 second delay. Fix would be to make sure the command is properly executed by gli even if there are spaces in the install path.