Ticket #554 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Incremental Building with GLI

Reported by: ak19 Owned by: oranfry
Priority: high Milestone: 2.83 Release
Component: Collection Building Severity: major
Keywords: incremental Cc:

Description

Since this seems to be a prodigious amount of work, it will be targeted at 2.83.

To carry on with the incremental build work here's what to do:

Go to <Oran's machine> and log in with <Oran's> username, <Oran's password?. My work so far is in the folder 'gsdl' (specifically 'gsdl/gli') on the Desktop. There are also some files on the Desktop named one.txt~seven.txt I've been using for testing. I've been testing on the collection 'test'.

I have added a static boolean variable called isCompleteBuild to the CollectionDesignManager? class which keeps track of whether a minimal or complete build was requested (see the code in CreatePanel? that sets it from the radio button).

I have mostly fixed importCollection() and buildCollection() in CollectionManager? to honour "isCompleteBuild". (Note that I totally removed the argument to buildCollection().)

I think that all that remains to do is to make sure that gli does not try to remove the index directory and rename building to index if the build was "minimal" (i.e., if "isCompleteBuild" is false). I'm not sure exactly where in GLI that happens though.

Also, we have to make sure that .col files (e.g., collect/test/test.col) does not have a line that turns the "removeold " flag, and that there is no gli code that tries to add this line to these files (there is currently some code in CollectionManager? that does exactly that!).

Change History

Changed 10 years ago by ak19

  • summary changed from Incremental Build with GLI to Incremental Building with GLI

Changed 10 years ago by ak19

  • owner changed from nobody to oranfry

Oran came back from his holidays and finished it.

Changed 10 years ago by ak19

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.