source: gs2-extensions/imagemagick/trunk/src/packages/README.txt@ 31804

Last change on this file since 31804 was 31804, checked in by ak19, 3 years ago

Not sure why I can't get the patched up libiconv to work with the gs- prefix, but trying for now without the prefix. Also updated the packages/README.TXT to mention that there's another gs- prefixed package (libxml), though I'm unable to track any record of the changes that were made to it for GS.

File size: 1.6 KB
Line 
1README
2
3This file tracks changes made to imagemagick/packages for Greenstone.
4
51. libxml2-2.9.0 seems to contain changes for Greenstone, resulting in a gs-libxml2-2.9.0 that we use instead.
6
7Not sure what the changes are. It was first committed with revision 30675 by Dr Bainbridge, not as the libxml version but directly as the gs-libxml version:
8http://trac.greenstone.org/browser/gs2-extensions/imagemagick/trunk/src/packages/gs-libxml2-2.9.0.tar.gz
9
10And CASCADE-MAKE/LIBXML.SH only states
11
12 libxml2.2.9.0 was modified for Greenstone to allow compilation to succeed on a Mac, so it has acquired a 'gs-' prefix
13
14
152. 13 July 2017
16ak19
17
18To get imagemagick's libiconv to compile up on Ubuntu 16.04 (a machine that contains perl 5.22.1, but where I was also trying with perl 5.24.x), I found that imagemagick failed to compile with an error about gets vs fgets. The error message was:
19
20
21> stdio.h:1010:1: error: ‘gets’ undeclared here (not in a function)
22> _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets
23> instead");
24
25The following was the solution, found at https://lists.gnu.org/archive/html/bug-gnu-libiconv/2016-04/msg00001.html
26
27******************************
28698c698,703
29< _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
30---
31> // Needs a patch to compile imagemagick (testing on Ubuntu v 16.04 LTS)
32> // https://gist.github.com/paulczar/5493708
33> // https://lists.gnu.org/archive/html/bug-gnu-libiconv/2016-04/msg00001.html
34> # if defined(__GLIBC__) && !defined(__UCLIBC__) && !__GLIBC_PREREQ(2, 16)
35> _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
36> # endif
37******************************
38
Note: See TracBrowser for help on using the repository browser.