Changeset 14390 for gsdl/trunk

Timestamp:

2007-08-31T10:13:38+12:00 (17 years ago)

Author:

mdewsnip

Message:

Efficiency improvement: only get the filter to retrieve metadata in get_children() if some has been requested. Otherwise, the filter makes an unnecessary request to the GDBM database for each child node. This makes a HUGE difference in some cases (eg. the NLNZ Papers Past newspapers collection).

File:

• gsdl/trunk/src/recpt/OIDtools.cpp (modified) (1 diff)

gsdl/trunk/src/recpt/OIDtools.cpp

@@ -210 +210 @@
   request.filterName = "BrowseFilter";
   request.filterLang = lang;
-  request.filterResultOptions = FROID | FRmetadata;
+  request.filterResultOptions = FROID;
+
+  // Efficiency improvement: only get the filter to retrieve metadata if some has been requested
+  // Otherwise, the filter makes an unnecessary request to the GDBM database for each child node
+  // By Michael Dewsnip, DL Consulting Ltd
+  if (metadata.size() > 0)
+  {
+    request.filterResultOptions |= FRmetadata;
+  }
+
   request.fields = metadata;
   request.getParents = getParents;