Changeset 15041 for greenstone3/trunk/src/java/org/greenstone/gsdl3/service/AbstractGS2FieldSearch.java

Timestamp:

2008-03-05T11:56:35+13:00 (16 years ago)

Author:

ak19

Message:

Attempted fix for http://trac.greenstone.org/ticket/245 - Java crash, index out of bounds

File:

• greenstone3/trunk/src/java/org/greenstone/gsdl3/service/AbstractGS2FieldSearch.java (modified) (1 diff)

greenstone3/trunk/src/java/org/greenstone/gsdl3/service/AbstractGS2FieldSearch.java

@@ -360 +360 @@
         getIndexData(fields, field_names, lang);
         // the field list -  read from config file
-        param = GSXML.createParameterDescription2(this.doc, name, getTextString("param."+name, lang), GSXML.PARAM_TYPE_ENUM_SINGLE, (String)fields.get(0), fields, field_names );
+        
+        // Fix for http://trac.greenstone.org/ticket/245 "java crash, index out of bounds"
+        // org.greenstone.gsdl3.service.AbstractGS2FieldSearch.createParameter(AbstractGS2FieldSearch.java:362)
+        // Changed from:
+        // param = GSXML.createParameterDescription2(this.doc, name, getTextString("param."+name, lang), GSXML.PARAM_TYPE_ENUM_SINGLE, (String)fields.get(0), fields, field_names );
+        String default_value = (fields.size() > 0) ? (String)fields.get(0) : null;
+              // don't want to access element 0 if fields.size()==0, and
+              // GSXML.createParameterDescription2 checks for default_value==null condition
+        param = GSXML.createParameterDescription2(this.doc, name, getTextString("param."+name, lang), GSXML.PARAM_TYPE_ENUM_SINGLE, default_value, fields, field_names );
         
     } else if (name.equals(FIELD_COMBINE_PARAM)) {