Changeset 15889

Timestamp:

2008-06-06T10:57:28+12:00 (16 years ago)

Author:

mdewsnip

Message:

Added "use strict", and fixed resulting problems.

Location:

gsdl/trunk/perllib

Files:

• arcinfo.pm (modified) (3 diffs)
• cfgread.pm (modified) (3 diffs)
• giget.pm (modified) (2 diffs)
• iso639.pm (modified) (2 diffs)

gsdl/trunk/perllib/arcinfo.pm

@@ -32 +32 @@
 # a file in the archives directory and an OID.
 
-
 package arcinfo;
 
@@ -40 +39 @@
 use constant INFO_FILE_INDEX    => 0;
 use constant INFO_STATUS_INDEX  => 1;
+
+use strict;
+
 
 # File format read in: OID <tab> Filename <tab> Optional-Index-Status
@@ -207 +209 @@
     my @list = ();
 
-    foreach $OID_order (@sorted_order) {
+    foreach my $OID_order (@sorted_order) {
     my $OID = $OID_order->[ORDER_OID_INDEX];
     my $OID_info = $self->{'info'}->{$OID};

gsdl/trunk/perllib/cfgread.pm

@@ -27 +27 @@
 
 package cfgread;
+
+use strict;
 
 
@@ -141 +143 @@
     
     if (open (COLCFG, ">$filename")) {
-    foreach $key (sort(keys(%$data))) {
+    foreach my $key (sort(keys(%$data))) {
         if ($key =~ /$stringexp/) {
         &write_cfg_line ('COLCFG', [$key, $data->{$key}]);
@@ -147 +149 @@
         &write_cfg_line ('COLCFG', [$key, @{$data->{$key}}]);
         } elsif ($key =~ /$hashexp/) {
-        foreach $k (keys (%{$data->{$key}})) {
+        foreach my $k (keys (%{$data->{$key}})) {
             &write_cfg_line ('COLCFG', [$key, $k, $data->{$key}->{$k}]);
         }
         } elsif ($key =~ /$arrayarrayexp/) {
-        foreach $k (@{$data->{$key}}) {
+        foreach my $k (@{$data->{$key}}) {
             &write_cfg_line ('COLCFG', [$key, @$k]);
         }
         } elsif ($key =~ /$hashhashexp/) {
-        foreach $k (keys (%{$data->{$key}})) {
-            foreach $p (keys (%{$data->{$key}->{$k}})) {
+        foreach my $k (keys (%{$data->{$key}})) {
+            foreach my $p (keys (%{$data->{$key}->{$k}})) {
             if ($p =~ /default/) {
                 &write_cfg_line ('COLCFG', 

gsdl/trunk/perllib/giget.pm

@@ +1 @@
+use strict;
+
 
 sub readin_html 
@@ -245 +247 @@
     my $nextpage_url = gi_query_url($search_terms);
     
-    $respage_fname = "$output_dir/respage1.html";
+    my $respage_fname = "$output_dir/respage1.html";
     get_gi_page($gi_base,$nextpage_url,$respage_fname);
     

gsdl/trunk/perllib/iso639.pm

@@ -3 +3 @@
 package iso639;
 
-%fromiso639 = (
+use strict;
+
+my %fromiso639 = (
            'aa' => 'Afar',
            'ab' => 'Abkhazian',
@@ -172 +174 @@
            );
 
-%toiso639 = (
+my %toiso639 = (
          'afar' => 'aa',
          'abkhazian' => 'ab',