Changeset 16103

Timestamp:

2008-06-23T12:05:20+12:00 (15 years ago)

Author:

ak19

Message:

To avoid a Content is not allowed in Prolog exception on the side of the client which receives the XML response messages, need to ensure that the XML returned does not have illegal chars like spaces at the start of the XML. Therefore, method processInternal now converts the response to a regular string (not formatted for display), trims it to remove any whitespace chars and prefixes the <xml> tag at the start just in case.

File:

• greenstone3/trunk/resources/java/QBRSOAPServer.java.in (modified) (1 diff)

greenstone3/trunk/resources/java/QBRSOAPServer.java.in

@@ -729 +729 @@
      * @return the XML response in String format. */
     protected String processInternal(Element message) {
-        LOG.debug(this.converter.getPrettyString(message));
+            if(LOG.isDebugEnabled()) { // or LOG.isEnabledFor(Level.DEBUG). 
+                                   // Testing for this improves efficiency
+            LOG.debug(this.converter.getPrettyString(message));
+        }
         
         // Let the messagerouter process the request message and get the response
-        Element response = mr.process(message);
-        // won't be null, MR always returns some response
-        
+        Element response = mr.process(message); 
+              // won't be null, MR always returns some response
+        
+        // In order to avoid "Content is not allowed in prolog" exception on the 
+        // web services' client end (problem encountered in GS mailing list), need 
+        // to make sure no characters (incl spaces) preceed the  XML sent back 
+        // from here. It may also require the <?xml?> tag at the very start.
+        return "<?xml version=\"1.0\" encoding=\"utf-8\"?>"
+            + this.converter.getString(response).trim();
         // Return it as a String formatted for display
-        return this.converter.getPrettyString(response);
+        // return this.converter.getPrettyString(response); 
+
     }